chore: tech-debt tier 1-2 — hygiene, audit refresh, F018/F041 fixes#121
Merged
Conversation
- Add .DS_Store to .gitignore (macOS Finder metadata). - Refresh docs/TECH_DEBT_AUDIT.md against the working tree: dated 2026-06-17 banner, tick completed quick-wins (F008/F009/F017/F029/ F046-F048/F051), mark F002 as partially split, update god-file LOC. - Flag F012 as obsolete: the remaining database.cpp std::cerr is the deliberate stall-watchdog (must not block on node locks); converting it to fc logging would defeat the watchdog.
- F041: replace std::exit(0) on the corrupted-db error path in
plugins/chain/plugin.cpp (x2) with appbase::app().quit() so shutdown
goes through the appbase sequence instead of bypassing it.
- F018: replace 'using namespace std;' in wallet.hpp with targeted
using std::{string,vector,map,pair}; (the only bare std names used).
optional/flat_set are fc types and resolve via existing usings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 1 (hygiene/docs) + the two cheapest Tier 2/3 code fixes from the refreshed tech-debt audit.
Changes
.gitignore— ignore.DS_Store.docs/TECH_DEBT_AUDIT.md— refresh against the working tree (May audit was 6 weeks stale): dated 2026-06-17 banner, tick completed quick-wins, update god-file LOC, mark F002 as partially split. Flags F012 as obsolete — the remainingdatabase.cppstd::cerris the deliberate stall-watchdog (must not block on node locks); converting it to fc logging would defeat the watchdog.plugins/chain/plugin.cpp) — replacestd::exit(0)×2 on the corrupted-db error path withappbase::app().quit(), per the existing TODO, so shutdown goes through the appbase sequence instead of bypassing it. (Fixes the bypassed-shutdown bug;quit()likely still exits 0, so this is not an exit-code change.)wallet.hpp) — replaceusing namespace std;with targetedusing std::{string,vector,map,pair};(verified the only bare std names used;optional/flat_setare fc types resolving via existing usings).Deferred
remote_node_api.hppplugin-namespace usings) — narrowing needs a local compiler: dozens of bare types (incl. bareset<>with nousing std::set) resolve through those usings via transitive leaks, so a blind edit would break the build across consumers.Verification
Relying on this PR's
docker-pr-buildfor build verification — the two code edits were not compiled locally. Both are high-confidence: F041 reuses anappbase::app().quit()call already present ~10× in the same TU; F018 was validated against a full template-token sweep of the header.