Handle Deno subprocess stdin failures#1418
Open
morluto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1415
Summary
The Deno subprocess runtime now observes and awaits stdin writes. If the child closes stdin during the initial protocol message or a tool-result write, execution returns a failed
ExecuteResultinstead of emitting an uncaught stream error or stalling.Changes
errorlistener for the subprocess lifetime.executorpatch changeset.Existing missing-Deno diagnostics remain unchanged.
Regression proof
On
origin/main, the regression emits an uncaughtEPIPEwhen the child closes stdin. When the uncaught event is intercepted by the harness, execution reaches its five-second guard without returning a result.With this change, the same execution returns
result: nullwith an actionable message containingFailed to write to Deno subprocess stdin: write EPIPE.Validation
git diff --checkpassed.origin/mainreturned no actionable findings.Limitations
The regression uses a Node subprocess fixture to deterministically exercise the shared stdin failure path without requiring a Deno installation. The existing real-Deno suite remains unchanged and was skipped by the environment.
The fixture is skipped on Windows because its subprocess signaling is POSIX-specific.
Review order
deno-worker-process.ts.