Prevent provider migration row ID collisions#1416
Open
morluto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1411
Summary
The provider service split migration generated target
row_idvalues with a 32-bit hash, then usedINSERT OR IGNORE. Distinct logical rows could collide, causing SQLite to discard one target row before the migration deleted both sources.executorpatch changeset.Regression proof
On
origin/main, the collision regression failed because onlyal4jix0bsurvived migration while both source rows were deleted.With this change, both
ypw3e5cbandal4jix0bare preserved as distinct migrated connections.A second SQLite regression injects an unrelated row with the generated target ID. The migration now returns
DataMigrationError, rolls back, and preserves both the source row and pre-existing target row.Compatibility and idempotency
Validation
git diff --checkpassed.origin/mainreturned no actionable findings.Review order
src/sqlite.test.ts.src/sqlite.ts.src/sqlite.ts.