Restore MCP request span export on the cloud worker#1410
Merged
Conversation
The Agents-bridge migration moved /mcp off the Effect app, so the auth path's Effect programs ran under the default no-op tracer and the mcp.request span (client fingerprint, rpc method, auth verdict) was created but never exported. Run those programs under the worker telemetry layer, open the http.server envelope span for MCP traffic at the worker edge, and propagate its context through the handler into the session DO so the whole request is one trace. currentPropagationHeaders now reads currentParentSpan instead of currentSpan so an external (edge) span still propagates into the DO. The e2e scenario asserts the contract against the exported store.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | cca1176 | Jul 14 2026, 06:35 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | cca1176 | Commit Preview URL Branch Preview URL |
Jul 14 2026, 06:33 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Agents-bridge migration, the /mcp auth path ran its Effect programs outside the app's tracer layer, so the mcp.request spans (client name/version, rpc method, auth verdict) were created but never exported. This restores the export: the worker opens the http.server envelope span for MCP traffic and the handler runs its programs under the worker telemetry layer, parented to that span, with the same trace propagated into the session DO.
The new e2e scenario asserts the contract against the exported trace store (motel), and fails on the pre-fix code.