Repository navigation
feat(cloudinary): expose the upload's public id and allow deleting an upload [Deel sync 3/5] - #4773
Open
gilgardosh wants to merge 1 commit into
Open
gilgardosh wants to merge 1 commit into
gilgardosh wants to merge 1 commit into
Conversation
Contributor
|
The latest changes of this PR are not available as |
gilgardosh
force-pushed
the
claude/deel-sync-3-cloudinary-delete
branch
from
October 20, 2026 15:15
3e06bfd to
6647918
Compare
Open
4 tasks done
… upload Uploads now also return Cloudinary's `publicId` and `resourceType` (optional fields; existing callers are unaffected), and `deleteUpload(publicId, resourceType)` removes a file — used next by the Deel sync to remove files of invoices whose save was rolled back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015CMcZduVAnhW3xJAtvmiQU
gilgardosh
force-pushed
the
claude/deel-sync-3-cloudinary-delete
branch
from
October 20, 2026 16:08
6647918 to
3449b82
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (Deel sync refactor), merge in order:
This change doesn't depend on PRs 1 and 2. It's stacked only to keep the merge order linear.
Summary
uploadInvoiceToCloudinaryalso returns Cloudinary'spublicIdandresourceType. Both fields are optional, so existing callers are unaffected.deleteUpload(publicId, resourceType), a wrapper aroundcloudinary.uploader.destroy.Test plan
email-ingestion-control.resolver.test.tsare also onmain.Generated by Claude Code