Skip to content

docs: correct the TerminalSteps agent count - #6329

Open
shabeeth2 wants to merge 3 commits into
Unity-Technologies:developfrom
shabeeth2:personal-review/C16-20261004
Open

shabeeth2 wants to merge 3 commits into
Unity-Technologies:developfrom
shabeeth2:personal-review/C16-20261004

Conversation

@shabeeth2

@shabeeth2 shabeeth2 commented Oct 4, 2026 •

Copy link
Copy Markdown

Proposed change(s)

Clarify that len(TerminalSteps) counts agents whose episodes ended since the last env.step(), including interruptions. This matches the class documentation and agent_id length implementation.

Source: TerminalSteps implementation.

Validation

Compared the sentence with the linked TerminalSteps implementation. Markdown preview and git diff --check passed.

Checklist

  • Documentation update.

@CLAassistant

CLAassistant commented Oct 4, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@shabeeth2
shabeeth2 marked this pull request as ready for review October 4, 2026 17:00
@shabeeth2 shabeeth2 changed the title docs: correct the TerminalSteps length explanation docs: correct the TerminalSteps agent count Oct 4, 2026

@montplaisir montplaisir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the documentation better! Please also fix line 95.

Updated the description of 'obs' in TerminalSteps to clarify the batch size context.

@shabeeth2 shabeeth2 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes to 95th line

@shabeeth2 shabeeth2 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@montplaisir montplaisir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants