Conversation
shabeeth2
marked this pull request as ready for review
October 4, 2026 17:00
montplaisir
requested changes
Oct 5, 2026
montplaisir
left a comment
Contributor
There was a problem hiding this comment.
Thank you for making the documentation better! Please also fix line 95.
Updated the description of 'obs' in TerminalSteps to clarify the batch size context.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Clarify that
len(TerminalSteps)counts agents whose episodes ended since the lastenv.step(), including interruptions. This matches the class documentation andagent_idlength implementation.Source:
TerminalStepsimplementation.Validation
Compared the sentence with the linked
TerminalStepsimplementation. Markdown preview andgit diff --checkpassed.Checklist