Skip to content

Guard SSPI teardown calls against NULL Curl_pSecFn #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dragos-dinulescu wants to merge 2 commits into from
Closed

Guard SSPI teardown calls against NULL Curl_pSecFn #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b93941
Guard SSPI teardown calls against NULL Curl_pSecFn
dragos-dinulescu Aug 25, 2026
7df747e
Remove comments from the SSPI teardown guards
dragos-dinulescu Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/vauth/digest_sspi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,8 @@ void Curl_auth_digest_cleanup(struct digestdata *digest)

/* Delete security context */
if(digest->http_context) {
Curl_pSecFn->DeleteSecurityContext(digest->http_context);
if(Curl_pSecFn)
Curl_pSecFn->DeleteSecurityContext(digest->http_context);
curlx_safefree(digest->http_context);
}

Expand Down
6 changes: 4 additions & 2 deletions lib/vauth/krb5_sspi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,14 +427,16 @@ void Curl_auth_cleanup_gssapi(struct kerberos5data *krb5)
{
/* Free our security context */
if(krb5->context) {
Curl_pSecFn->DeleteSecurityContext(krb5->context);
if(Curl_pSecFn)
Curl_pSecFn->DeleteSecurityContext(krb5->context);
curlx_free(krb5->context);
krb5->context = NULL;
}

/* Free our credentials handle */
if(krb5->credentials) {
Curl_pSecFn->FreeCredentialsHandle(krb5->credentials);
if(Curl_pSecFn)
Curl_pSecFn->FreeCredentialsHandle(krb5->credentials);
curlx_free(krb5->credentials);
krb5->credentials = NULL;
}
Expand Down
6 changes: 4 additions & 2 deletions lib/vauth/ntlm_sspi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,14 +324,16 @@ void Curl_auth_cleanup_ntlm(struct ntlmdata *ntlm)
{
/* Free our security context */
if(ntlm->context) {
Curl_pSecFn->DeleteSecurityContext(ntlm->context);
if(Curl_pSecFn)
Curl_pSecFn->DeleteSecurityContext(ntlm->context);
curlx_free(ntlm->context);
ntlm->context = NULL;
}

/* Free our credentials handle */
if(ntlm->credentials) {
Curl_pSecFn->FreeCredentialsHandle(ntlm->credentials);
if(Curl_pSecFn)
Curl_pSecFn->FreeCredentialsHandle(ntlm->credentials);
curlx_free(ntlm->credentials);
ntlm->credentials = NULL;
}
Expand Down
6 changes: 4 additions & 2 deletions lib/vauth/spnego_sspi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,14 +312,16 @@ void Curl_auth_cleanup_spnego(struct negotiatedata *nego)
{
/* Free our security context */
if(nego->context) {
Curl_pSecFn->DeleteSecurityContext(nego->context);
if(Curl_pSecFn)
Curl_pSecFn->DeleteSecurityContext(nego->context);
curlx_free(nego->context);
nego->context = NULL;
}

/* Free our credentials handle */
if(nego->credentials) {
Curl_pSecFn->FreeCredentialsHandle(nego->credentials);
if(Curl_pSecFn)
Curl_pSecFn->FreeCredentialsHandle(nego->credentials);
curlx_free(nego->credentials);
nego->credentials = NULL;
}
Expand Down
Loading