[EmandM]

Purpose of this PR

Our standards check was checking the standards of the N4E binaries as well as our own. This PR excludes those binaries as we cannot fix them in this repo.

Jira ticket

Changelog

• Fixed: CI things

Documentation

• No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

• Manual testing done

Automated tests:

• Covered by existing automated tests
• Covered by new automated tests

Does the change require QA team to:

• Review automated tests?
• Execute manual tests?
• Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

not applicable

Backports

Not needed as N4E was only added as a dependency in 3.x

[u-pr]

💡 Harness Review

The change adds analyzer exclusions to the standards tool and aligns the bootstrap field with repository naming rules. I examined all changed code, the target-file packaging configuration, and CI invocation, and found no actionable issues.

_{Reviewed commit 0a7e3d0}

_{🤖 Helpful? 👍/👎}

[NoelStephensUnity]

Nice catch on the naming convention as well as the removal of DLLs!

[michalChrobot]

Nice catch, did you see that failing on a PR?

[codecov-github-com]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...cts/Runtime/Components/Helpers/UnifiedBootstrap.cs	0.00%	5 Missing ⚠️

@@              Coverage Diff               @@
##           develop-3.x.x    #4197   +/-   ##
==============================================
  Coverage          76.03%   76.03%           
==============================================
  Files                159      159           
  Lines              27344    27344           
==============================================
  Hits               20791    20791           
  Misses              6553     6553           

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu	75.07% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...cts/Runtime/Components/Helpers/UnifiedBootstrap.cs	0.00% <0.00%> (ø)

Components	Coverage Δ
com.unity.netcode.gameobjects	76.03% <0.00%> (ø)

ℹ️ Need help interpreting these results?

[EmandM]

Nice catch, did you see that failing on a PR?

It was doing weird things when I ran it locally. The N4E stuff never resolved because the code generators failed to run, so it would try run a build of the code, log an exception, wait for ages, and then run on NGO as normal.

I often run the tool locally so it was annoying 😄