Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice seeing that the reloadLogs issue has been fixed in the development branch already!
This PR adds a regression test for Unitech/pm2#5509 to test/e2e/logs/log-reload.sh.
In fork mode, pm2
reloadLogsworked the first time, then failed on every later call when a log path was/dev/nullorNULL:The real log files were never reopened, so PM2 kept writing to the rotated files. With
logrotate, the logs grew without limit. This still happens on the latest (7.0.4) releasedevelopmentalready fixes it inStdioLogger.close(theif (stds[k] && stds[k]._file)guard). There is no test for it yet, so this adds one to keep it fixed.Test
Fork mode,
-o /dev/null -e err-rel.log. The test deletes the error log, runsreloadLogs, checks the log is recreated, then does the same a second time.master/ 7.0.4: the second check fails.development: all checks pass.