Fix and improve bot "🤖 Upstream testing failure" posts - #1629
Open
Sevans711 wants to merge 4 commits into
Open
Conversation
Fixes #1591, Upstream-ci bot post not noticeable enough.
Sevans711
marked this pull request as ready for review
July 29, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1619
Closes #1591
Overview
Fixes typo in upstream-dev-ci.yml which led to always running the "make or update bot issue post reporting failed upstream-ci" commands, regardless of whether the upstream-ci actually succeeded. (See #1619.) The old version was checking if
needs.upstream-dev.testresults != 'success'; the corrected version is checking ifneeds.upstream-dev.outputs.testresults != 'success'instead.Updates title for bot issue reporting failed upstream-ci; now the post's title should include date of failure. When the bot updates the post, the title will update accordingly as well. (See #1591.)
Keeping as draft PR until I figure out how to properly test these changes before merging….EDIT: see tests below.Testing these changes
I ran tests on my fork to see how this behaves, with some small changes to the workflow file to allow me to run it on my fork, repeatedly, while forcing failure / success each time as desired.
To know that issue #1619 is properly fixed, we should observe:
Indeed, that is what happened. I did the following steps, in this order:
To know that issue #1591 is properly addressed, we should observe:
Steps from above demonstrate (A) properly already; The issue (Sevans711#2) includes a date in the title.
To demonstrate (B) without needing to wait a whole day, I made another branch (
testing_upstream-ci_bot_post_title) on my fork and updated the .yml file; the only update was adding-%H:%Minto line 105:issue_title="${title_prefix} ($(date -u +%Y-%m-%d-%H:%M))"for testing purposes.Then, I ran two failed CI Upstream jobs. The first job created the issue Sevans711#3, and the second job updated the issue's title appropriately, as demonstrated by the edit history on that issue.
PR Checklist
General
Claude helped with finding these bugs and suggesting code edits. I reviewed, made additional changes, and take responsibility for all revisions.