Skip to content

Fix and improve bot "🤖 Upstream testing failure" posts - #1629

Open
Sevans711 wants to merge 4 commits into
mainfrom
upstream-ci-failure_bot_post_fixes
Open

Fix and improve bot "🤖 Upstream testing failure" posts#1629
Sevans711 wants to merge 4 commits into
mainfrom
upstream-ci-failure_bot_post_fixes

Conversation

@Sevans711

@Sevans711 Sevans711 commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Closes #1619
Closes #1591

Overview

Fixes typo in upstream-dev-ci.yml which led to always running the "make or update bot issue post reporting failed upstream-ci" commands, regardless of whether the upstream-ci actually succeeded. (See #1619.) The old version was checking if needs.upstream-dev.testresults != 'success'; the corrected version is checking if needs.upstream-dev.outputs.testresults != 'success' instead.

Updates title for bot issue reporting failed upstream-ci; now the post's title should include date of failure. When the bot updates the post, the title will update accordingly as well. (See #1591.)

Keeping as draft PR until I figure out how to properly test these changes before merging…. EDIT: see tests below.

Testing these changes

I ran tests on my fork to see how this behaves, with some small changes to the workflow file to allow me to run it on my fork, repeatedly, while forcing failure / success each time as desired.

To know that issue #1619 is properly fixed, we should observe:

  • (A) No issue posted on initial upstream-ci pipeline success.
  • (B) Issue gets posted on failure.
  • (C) No update to issue on subsequent success.
  • (D) Issue gets updated on subsequent failure.
  • (E) No issue posted on subsequent success after older issue gets closed.

Indeed, that is what happened. I did the following steps, in this order:

  1. Successful CI Upstream run. No corresponding issue was posted; this confirms (A).
  2. Failed CI Upstream run. A corresponding issue was posted (see 🤖 Upstream testing failure (2026-07-29) Sevans711/uxarray#2). This confirms (B). (The issue has since been edited and marked as closed, as per steps (4) and (5) below.)
  3. Another successful CI Upstream run. The corresponding issue was NOT updated; this confirms (C).
  4. Another failed CI Upstream run. The corresponding issue WAS updated; this confirms (D).
  5. Closed the issue.
  6. One last successful CI Upstream run. Indeed, no issue was posted; this confirms (E).

To know that issue #1591 is properly addressed, we should observe:

  • (A) title includes date.
  • (B) title updates upon subsequent failure.

Steps from above demonstrate (A) properly already; The issue (Sevans711#2) includes a date in the title.

To demonstrate (B) without needing to wait a whole day, I made another branch (testing_upstream-ci_bot_post_title) on my fork and updated the .yml file; the only update was adding -%H:%M into line 105: issue_title="${title_prefix} ($(date -u +%Y-%m-%d-%H:%M))" for testing purposes.

Then, I ran two failed CI Upstream jobs. The first job created the issue Sevans711#3, and the second job updated the issue's title appropriately, as demonstrated by the edit history on that issue.

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Claude helped with finding these bugs and suggesting code edits. I reviewed, made additional changes, and take responsibility for all revisions.

@Sevans711 Sevans711 added CI Continuous Integration github_actions Pull requests that update GitHub Actions code labels Jul 29, 2026
@Sevans711 Sevans711 added the developer experience Makes the codebase easier to read, debug, maintain, or extend. label Jul 29, 2026
@Sevans711
Sevans711 marked this pull request as ready for review July 29, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration developer experience Makes the codebase easier to read, debug, maintain, or extend. github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot posted "🤖 Upstream testing failure" despite upstream ci success Upstream-ci failure bot issue post not noticeable enough

1 participant