fix(bot-oo): make settlement lists include-only#4961
Merged
Conversation
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
marked this pull request as ready for review
July 24, 2026 16:48
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Reinis-FRP
previously approved these changes
Jul 27, 2026
Reinis-FRP
left a comment
Contributor
There was a problem hiding this comment.
thanks, using receipt based filtering for include list and dropping support for exclude list in MOOv2 makes sense
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
This reverts commit e743eb7. Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Reinis-FRP
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SETTLE_INCLUDE_LISTremains restrictive.Test plan
TIME_LOOKBACK.git diff --checkpass locally.monitor-v2tests.