Skip to content

fix(bot-oo): make settlement lists include-only#4961

Merged
md0x merged 6 commits into
masterfrom
pablo/managed-oo-direct-includes
Jul 27, 2026
Merged

fix(bot-oo): make settlement lists include-only#4961
md0x merged 6 commits into
masterfrom
pablo/managed-oo-direct-includes

Conversation

@md0x

@md0x md0x commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove exclude-list settlement support from the bot; stale exclude-list configuration now fails at startup instead of being ignored.
  • Preserve standard OOv2 behavior when no include list is configured, while an explicit SETTLE_INCLUDE_LIST remains restrictive.
  • Preserve normal time-range discovery and settlement of resolved Managed OOv2 disputes.
  • Require non-resolved Managed OOv2 requests to be explicitly included; Managed defaults to an empty include list.
  • Fetch Managed includes directly, then merge and deduplicate them with normal candidates; lookup failures fail closed without blocking resolved disputes.
  • Preserve OOv1 and Skinny OO behavior.

Test plan

  • Added coverage for resolved Managed disputes with empty and invalid includes.
  • Added coverage for empty Managed includes and direct includes outside TIME_LOOKBACK.
  • Added coverage that the removed exclude-list setting fails for every oracle type, including empty values.
  • Retained coverage for standard OOv2 with an empty, populated, or absent include list.
  • ESLint, Prettier, and git diff --check pass locally.
  • CircleCI build, lint, general tests, and monitor-v2 tests.

Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x
md0x marked this pull request as ready for review July 24, 2026 16:48
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x md0x changed the title fix(bot-oo): fetch managed include events directly fix(bot-oo): preserve managed disputes with direct includes Jul 27, 2026
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x md0x changed the title fix(bot-oo): preserve managed disputes with direct includes fix(bot-oo): require managed settlement includes Jul 27, 2026
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x md0x changed the title fix(bot-oo): require managed settlement includes fix(bot-oo): make settlement lists include-only Jul 27, 2026
Reinis-FRP
Reinis-FRP previously approved these changes Jul 27, 2026

@Reinis-FRP Reinis-FRP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, using receipt based filtering for include list and dropping support for exclude list in MOOv2 makes sense

Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x md0x changed the title fix(bot-oo): make settlement lists include-only fix(bot-oo): restrict managed settlements to includes Jul 27, 2026
This reverts commit e743eb7.

Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
@md0x md0x changed the title fix(bot-oo): restrict managed settlements to includes fix(bot-oo): make settlement lists include-only Jul 27, 2026
@md0x
md0x requested a review from Reinis-FRP July 27, 2026 11:10
@md0x
md0x merged commit 9b8b229 into master Jul 27, 2026
7 checks passed
@md0x
md0x deleted the pablo/managed-oo-direct-includes branch July 27, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants