fix: restore partial modifier on compression ExtensionTests classes#1059
Merged
Conversation
PR #1058 removed the partial modifier from the two compression ExtensionTests classes as an analyzer code smell, but both classes have a second partial declaration in ExtensionTests.Async.cs that is only compiled when FEATURE_COMPRESSION_ASYNC is defined (net10.0 and higher). This broke the net10.0 build on main with CS0260. The analyzer finding is a false positive caused by the conditional compilation of the companion file.
|
|
This is addressed in release v7.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1058 removed the partial modifier from the two compression ExtensionTests classes as an analyzer code smell, but both classes have a second partial declaration in ExtensionTests.Async.cs that is only compiled when FEATURE_COMPRESSION_ASYNC is defined (net10.0 and higher). This broke the net10.0 build on main with CS0260.
The analyzer finding is a false positive caused by the conditional compilation of the companion file.