refactor!: expose ZipArchive/ZipFile as extension properties#1056
Merged
Conversation
Convert the `ZipArchive()` and `ZipFile()` extension methods on `IFileSystem` in the Compression package to C# 14 extension properties, so they are accessed as `fileSystem.ZipArchive` / `fileSystem.ZipFile` without the trailing parentheses. BREAKING CHANGE: `IFileSystem.ZipArchive()` and `IFileSystem.ZipFile()` are now properties (`.ZipArchive` / `.ZipFile`). Existing callers must drop the parentheses and recompile.
Follow-up to the extension-property conversion: update the Compression package README examples to access `fileSystem.ZipFile` / `fileSystem.ZipArchive` without the trailing parentheses.
vbreuss
force-pushed
the
refactor/zip-extension-properties
branch
from
83492be to
5359b4f
Compare
|
|
This is addressed in release v7.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the
ZipArchive()andZipFile()extension methods onIFileSystemin the Compression package to C# 14 extension properties, so they are accessed asfileSystem.ZipArchive/fileSystem.ZipFilewithout the trailing parentheses.BREAKING CHANGE:
IFileSystem.ZipArchive()andIFileSystem.ZipFile()are now properties (.ZipArchive/.ZipFile). Existing callers must drop the parentheses and recompile.