Add MacOS fix for serving DHCP IP broadcast#1990
Open
nicholas-shi wants to merge 3 commits into
Open
Conversation
Member
|
Thanks for the PR. The implementation here has race condition so it is going to fail to work at times when the server receives requests concurrently. Have you tried by just removing the |
Author
|
Ah, that would have been much easier. Just removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MacOS host systems, there is an issue with DHCP broadcasting IP addresses which results in a Network Unreachable error (#1674).
Based off of fix from insomniacslk/dhcp#378