Skip to content

fix(membership): let Qgiv embed height flex on membership/supporting-member #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanadft merged 2 commits into from
Aug 18, 2026
Merged

fix(membership): let Qgiv embed height flex on membership/supporting-member #528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d99fb5
fix(membership): let Qgiv embed height flex instead of capping at 720px
mohanadft Aug 18, 2026
6c7ce53
fix(membership): cap Qgiv embed height at 950px instead of leaving it…
mohanadft Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/components/membership/QgivJoin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,12 +245,11 @@ export default function QgivJoin({ tier, className, prefill }: QgivJoinProps) {
{/* Qgiv's embed.js sets a default iframe height (observed: 1000px) via
the `height` HTML attribute, then narrows it once its resize
postMessage fires — which hasn't reliably landed here, leaving dead
space below the visibly shorter membership form. `/donate` and
`/donate-new` hit the same issue and fix it the same way: a plain
CSS rule beats an HTML attribute in the cascade without needing
`!important`, capping the iframe box directly rather than a
wrapping element Qgiv's script may detach from. */}
<style>{`.qgiv-embed-container iframe.qgiv-embed { max-height: 720px; }`}</style>
space below the visibly shorter membership form. Capping at 950px
(vs. clamping to something like 720px) still fits the tallest
real-world variant of the form while trimming the worst of the
unresized default. */}
<style>{`.qgiv-embed-container iframe.qgiv-embed { max-height: 950px; }`}</style>
</div>
);
}
Loading