홈 화면 타이틀 텍스트 변경 - #931
Conversation
- `HomeFragment.kt`: 로그인한 사용자에게 개인화된 추천 문구(`%s님을 위한 추천글`)를 노출하고, 텍스트 배치를 위해 아이콘 숨김 및 제약 조건(Constraint)을 조정하는 로직 추가 - `fragment_home.xml`: 라이징 피드 타이틀 `TextView`에 ID(`tv_home_rising_feed`) 추가 - `strings.xml`: 사용자 닉네임을 포함하는 개인화 문구 리소스(`home_rising_feed_for_user`) 추가
|
Warning Review limit reached
Next review available in: 29 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Walkthrough홈 화면에 로그인 사용자 이름을 포함한 상승 피드 제목을 추가했습니다. 로그인 상태에서 로딩과 오류가 없으면 핫 아이콘을 숨기고 제목의 위치와 여백을 조정합니다. Changes홈 화면 상승 피드 제목
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/com/into/websoso/ui/main/home/HomeFragment.kt`:
- Around line 153-164: Update HomeFragment’s login-state handling so changes
from MainViewModel.isLogin trigger UI rendering, including logout restoration of
ivHomeHot and tvHomeRisingFeed to their default state. Add a dedicated isLogin
observer or include login status in mainUiState, and route both login and logout
states through a shared rendering function rather than only observing
mainUiState.
- Around line 153-164: Update MainViewModel.updateUserInfo() so retry initiation
and successful user-info handling both reset error to false. Ensure a failed
request followed by a successful retry clears uiState.error, allowing
HomeFragment’s mainUiState observer to display the personalized title.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c815f8ce-8354-4bf1-9c44-94335a86e7e6
📒 Files selected for processing (3)
app/src/main/java/com/into/websoso/ui/main/home/HomeFragment.ktapp/src/main/res/layout/fragment_home.xmlcore/resource/src/main/res/values/strings.xml
- `HomeFragment.kt`: 로그인 상태에 따라 'HOT' 아이콘 가시성과 타이틀 위치를 동적으로 변경하던 로직 삭제 및 닉네임 업데이트 로직 간소화 - `fragment_home.xml`: 'HOT' 아이콘(`iv_home_hot`) 삭제 및 라이징 피드 타이틀(`tv_home_rising_feed`)을 부모 컨테이너 왼쪽에 고정되도록 레이아웃 수정
- `MainViewModel.kt`: 유저 정보 요청 시작 및 성공 시 `mainUiState`의 `error` 상태를 `false`로 명시적으로 업데이트하도록 수정
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Summary by CodeRabbit