Skip to content

chore(preact-query*): enable '@typescript-eslint/array-type' and '@typescript-eslint/no-unnecessary-type-assertion' #11925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 2 commits into from
Oct 8, 2026
Merged

chore(preact-query*): enable '@typescript-eslint/array-type' and '@typescript-eslint/no-unnecessary-type-assertion' #11925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3721dc2
chore(preact-query*): enable '@typescript-eslint/array-type' and '@ty…
sukvvon Oct 8, 2026
1182cab
Merge branch 'main' into chore/preact-query-array-type-and-type-asser…
sukvvon Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/preact-query-devtools/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ export default defineConfig([
'no-import-assign': 'off',
// TS-aware version handles overloads correctly
'@typescript-eslint/no-redeclare': 'error',
'@typescript-eslint/array-type': 'off',
'@typescript-eslint/no-unnecessary-type-assertion': 'off',
'@typescript-eslint/no-unnecessary-condition': 'off',
},
},
Expand Down
2 changes: 0 additions & 2 deletions packages/preact-query-persist-client/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ export default defineConfig([
'no-import-assign': 'off',
// TS-aware version handles overloads correctly
'@typescript-eslint/no-redeclare': 'error',
'@typescript-eslint/array-type': 'off',
'@typescript-eslint/no-unnecessary-type-assertion': 'off',
'@typescript-eslint/no-unnecessary-condition': 'off',
},
},
Expand Down
2 changes: 0 additions & 2 deletions packages/preact-query/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ export default defineConfig([
'no-import-assign': 'off',
// TS-aware version handles overloads correctly
'@typescript-eslint/no-redeclare': 'error',
'@typescript-eslint/array-type': 'off',
'@typescript-eslint/no-unnecessary-type-assertion': 'off',
'@typescript-eslint/no-unnecessary-condition': 'off',
},
},
Expand Down
4 changes: 2 additions & 2 deletions packages/preact-query/src/__tests__/ErrorBoundary/ErrorBoundary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class ErrorBoundary extends Component<
return { didCatch: true, error }
}

resetErrorBoundary(...args: any[]) {
resetErrorBoundary(...args: Array<any>) {
const { error } = this.state

if (error !== null) {
Expand Down Expand Up @@ -126,7 +126,7 @@ export class ErrorBoundary extends Component<
}
}

function hasArrayChanged(a: any[] = [], b: any[] = []) {
function hasArrayChanged(a: Array<any> = [], b: Array<any> = []) {
return (
a.length !== b.length || a.some((item, index) => !Object.is(item, b[index]))
)
Expand Down
2 changes: 1 addition & 1 deletion packages/preact-query/src/__tests__/ErrorBoundary/ErrorBoundaryContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { createContext } from 'preact'
type ErrorBoundaryContextType = {
didCatch: boolean
error: any
resetErrorBoundary: (...args: any[]) => void
resetErrorBoundary: (...args: Array<any>) => void
}

export const ErrorBoundaryContext =
Expand Down
12 changes: 8 additions & 4 deletions packages/preact-query/src/__tests__/ErrorBoundary/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type {

export type FallbackProps = {
error: any
resetErrorBoundary: (...args: any[]) => void
resetErrorBoundary: (...args: Array<any>) => void
}

type PropsWithChildren<TProps = {}> = TProps & {
Expand All @@ -18,10 +18,14 @@ type ErrorBoundarySharedProps = PropsWithChildren<{
onError?: (error: Error, info: ErrorInfo) => void
onReset?: (
details:
| { reason: 'imperative-api'; args: any[] }
| { reason: 'keys'; prev: any[] | undefined; next: any[] | undefined },
| { reason: 'imperative-api'; args: Array<any> }
| {
reason: 'keys'
prev: Array<any> | undefined
next: Array<any> | undefined
},
) => void
resetKeys?: any[]
resetKeys?: Array<any>
}>

type ErrorBoundaryPropsWithComponent = ErrorBoundarySharedProps & {
Expand Down
4 changes: 1 addition & 3 deletions packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,9 +1153,7 @@ describe('useSuspenseQuery', () => {
function Page() {
return (
<div>
<button
onClick={() => queryClient.setQueryData(key, undefined as any)}
>
<button onClick={() => queryClient.setQueryData(key, undefined)}>
set undefined
</button>
<Suspense fallback="loading">
Expand Down
Loading