test(lit-query): replace inline 'new Promise' timeouts with 'sleep' from 'query-test-utils' by sukvvon · Pull Request #11104 · TanStack/query

sukvvon · 2026-07-22T02:44:31Z

🎯 Changes

lit-query's tests were the only ones in the repo still writing new Promise((resolve) => setTimeout(resolve, N)) inline instead of using the shared sleep(N) helper from @tanstack/query-test-utils that every other adapter package's tests already use. Added @tanstack/query-test-utils as a devDependency and replaced all 14 occurrences across client-switch-controllers.test.ts, counters-and-state.test.ts, mutation-controller.test.ts, and query-controller.test.ts. No behavior change — sleep is implemented identically to the inlined promise.

Left untouched: promises that resolve manually via a captured resolve reference (e.g. resolveRefetch, resolveOld, resolveFetch), since those aren't fixed-delay timeouts.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Improved the reliability and consistency of timing-based automated tests.
- Standardized asynchronous wait handling across query and mutation scenarios.
Chores
- Added shared test utilities to support consistent test execution.

…rom 'query-test-utils'

coderabbitai · 2026-07-22T02:44:53Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bf074827-008a-4590-bdf8-66b8a6fecdd5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

📝 Walkthrough

Walkthrough

The Lit Query package adds @tanstack/query-test-utils as a development dependency and replaces inline setTimeout-based test delays with the shared sleep helper across controller and state tests.

Changes

Lit Query test timing utility adoption

Layer / File(s)	Summary
Shared sleep utility adoption `packages/lit-query/package.json`, `packages/lit-query/src/tests/client-switch-controllers.test.ts`, `packages/lit-query/src/tests/counters-and-state.test.ts`, `packages/lit-query/src/tests/mutation-controller.test.ts`	Adds the test utility dependency and replaces inline timer Promises with `sleep` in client-switch, counter, and mutation tests.
Query controller sleep migration `packages/lit-query/src/tests/query-controller.test.ts`	Replaces inline timer Promises with `sleep` across query transition, cancellation, lifecycle, retry, provider, and hydration tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: replacing inline timeouts in lit-query tests with the shared sleep helper.
Description check	✅ Passed	The description follows the required template and includes the changes, checklist, and release impact sections with sufficient detail.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/lit-query-sleep-helper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-07-22T02:44:58Z

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

_{To disable these notifications, a workspace admin can disable them in workspace settings.}

View your CI Pipeline Execution ↗ for commit 9c805d1

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	❌ Failed	1m 39s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-08-19 01:25:15 UTC

github-actions · 2026-07-22T02:45:32Z

🚀 Changeset Version Preview

9 package(s) bumped directly, 16 bumped as dependents.

🟨 Minor bumps

Package	Version	Reason
`@tanstack/angular-query-experimental`	5.101.4 → 5.102.0	Changeset
`@tanstack/eslint-plugin-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/preact-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/query-core`	5.101.4 → 5.102.0	Changeset
`@tanstack/react-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/solid-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/vue-query`	5.101.4 → 5.102.0	Changeset
`@tanstack/angular-query-persist-client`	5.101.4 → 5.102.0	Dependent
`@tanstack/preact-query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/preact-query-persist-client`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-async-storage-persister`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-broadcast-client-experimental`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-persist-client-core`	5.101.4 → 5.102.0	Dependent
`@tanstack/query-sync-storage-persister`	5.101.4 → 5.102.0	Dependent
`@tanstack/react-query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/react-query-next-experimental`	5.101.4 → 5.102.0	Dependent
`@tanstack/react-query-persist-client`	5.101.4 → 5.102.0	Dependent
`@tanstack/solid-query-devtools`	5.101.4 → 5.102.0	Dependent
`@tanstack/solid-query-persist-client`	5.101.4 → 5.102.0	Dependent

🟩 Patch bumps

Package	Version	Reason
`@tanstack/lit-query`	0.2.11 → 0.2.12	Changeset
`@tanstack/svelte-query`	6.1.38 → 6.1.39	Changeset
`@tanstack/svelte-query-devtools`	6.1.38 → 6.1.39	Dependent
`@tanstack/svelte-query-persist-client`	6.1.38 → 6.1.39	Dependent
`@tanstack/vue-query-devtools`	6.1.38 → 6.1.39	Dependent

pkg-pr-new · 2026-07-22T02:48:24Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11104

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11104

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11104

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11104

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11104

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11104

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11104

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11104

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11104

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11104

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11104

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11104

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11104

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11104

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11104

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11104

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11104

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11104

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11104

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11104

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11104

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11104

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11104

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11104

commit: 9c805d1

github-actions · 2026-07-22T02:49:03Z

size-limit report 📦

Path	Size
react full	12.29 KB (0%)
react minimal	9.23 KB (0%)

TkDodo · 2026-08-18T19:21:14Z

@sukvvon there’s something not quite right here, errors are persistent. do you want to get this over the finish line or should we close it?

sukvvon · 2026-08-19T01:08:21Z

@TkDodo Let's finish it. lit-query is the only package on moduleResolution: NodeNext, tripping TS2835 on query-test-utils's imports. Once #10943 merges and drops that override, this is fixed — verified locally.

… 'testHost.ts'

test(lit-query): replace inline 'new Promise' timeouts with 'sleep' f…

64ad8e5

…rom 'query-test-utils'

sukvvon self-assigned this Jul 22, 2026

sukvvon marked this pull request as draft July 22, 2026 07:52

TkDodo approved these changes Aug 18, 2026

View reviewed changes

Merge branch 'main' into test/lit-query-sleep-helper

6f08222

Merge branch 'main' into test/lit-query-sleep-helper

844bfec

sukvvon requested a review from TkDodo August 19, 2026 01:10

test(lit-query): replace inline 'new Promise' timeout with 'sleep' in…

9c805d1

… 'testHost.ts'

Navigation Menu

Uh oh!

Uh oh!

test(lit-query): replace inline 'new Promise' timeouts with 'sleep' from 'query-test-utils' - #11104

test(lit-query): replace inline 'new Promise' timeouts with 'sleep' from 'query-test-utils'#11104
sukvvon wants to merge 4 commits into
mainfrom
test/lit-query-sleep-helper

sukvvon commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

TkDodo commented Aug 18, 2026

Uh oh!

sukvvon commented Aug 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

sukvvon commented Jul 22, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Nx Cloud AI Fix Eligible

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

🟨 Minor bumps

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

TkDodo commented Aug 18, 2026

Uh oh!

sukvvon commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Jul 22, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 22, 2026 •

edited

Loading

nx-cloud Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

pkg-pr-new Bot commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading

sukvvon commented Aug 19, 2026 •

edited

Loading