fix: replace experimentalDts with dts to fix TS2883 with nodenext module resolution - #11072
fix: replace experimentalDts with dts to fix TS2883 with nodenext module resolution#11072lokesh-7977 wants to merge 4 commits into
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pull request replaces Changestsup declaration configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
32a9c45 to
e97820b
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 8m 34s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
❌ Failed | 6s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-08-18 08:05:28 UTC
|
sadly this fails the build now. we have plans to move away from |
|
Got it. Since the |

🎯 Changes
Replace
experimentalDts: truewithdts: truein all tsup configs to fixTS2883 errors when using
module: "nodenext"with declaration emit.experimentalDtsgenerates a shared_tsup-dts-rollup.cjsfile that TypeScriptcannot reference portably from
.d.ctsre-exports under nodenext resolution.Switching to
dtsgenerates per-entry declaration files, eliminating theproblematic internal path.
✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit