Papers3 improvements

[Shadowtrance]

And Tab5 keyboard improvements
Usb host keyboard improvements
SYMBOLS
Requires the device.py change from CL-32 PR but that only affects visuals and not build breaking

Summary by CodeRabbit

• New Features

  • Added support for 8-bit grayscale displays and partial screen updates.
  • Added separate Ctrl and Alt modifier reporting for keyboard and USB input.
  • Improved HTTPS certificate validation and system-service compatibility.

• Bug Fixes

  • Preserved modifier state during queued input and key repeats.
  • Improved key-repeat timing and event processing responsiveness.
  • Automatically clears displays after startup.

• Performance

  • Improved display rendering by using external memory where appropriate.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d9830291-cae6-4058-99f9-387dbd5aae8b

📥 Commits

Reviewing files that changed from the base of the PR and between 2c1085c and 4261407.

📒 Files selected for processing (1)

• Devices/m5stack-papers3/source/drivers/papers3_display.cpp

💤 Files with no reviewable changes (1)

• Devices/m5stack-papers3/source/drivers/papers3_display.cpp

---

📝 Walkthrough

Walkthrough

The PR adds GRAYSCALE8 tile support and external-RAM buffer allocation for displays. It updates the Papers3 driver to pack grayscale pixels and perform a post-boot clear. Keyboard events now preserve Ctrl and Alt separately, including queued and repeated Tab5 events. USB HID conversion emits modifier metadata without suppressing characters. Additional HTTP, FreeRTOS, POSIX, VFS, logging, compression, and filesystem symbols are exported.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the PaperS3 display changes, which are part of the pull request, but it omits the keyboard and symbol-support changes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 6

🧹 Nitpick comments (1)

TactilityC/Source/tt_init.cpp (1)

266-272: 🩺 Stability & Availability | 🔵 Trivial

Tie global logging and VFS hooks to module teardown.

A dynamically loaded app can install callbacks that firmware uses after the call returns. If the module unloads first, esp_log_set_vprintf can leave a formatter pointer into unloaded code. esp_vfs_register can leave VFS callbacks pointing into unloaded code. ESP-IDF does not take ownership of the registered esp_vfs_t callback table. (docs.espressif.com)

Ensure teardown restores the previous log formatter and unregisters every VFS path before unloading the module. Prefer scoped wrappers if the loader cannot enforce this contract.

#!/bin/bash
set -euo pipefail

rg -n -C 8 'esp_log_set_vprintf|esp_vfs_register|esp_vfs_unregister|module_(stop|remove|destruct)|unload' .

Also applies to: 358-363

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a7a1017b-d82d-4901-b8da-e0bc22983378

📥 Commits

Reviewing files that changed from the base of the PR and between d2c69ee and aacadc4.

📒 Files selected for processing (14)

• Devices/m5stack-papers3/source/drivers/papers3_display.cpp
• Devices/m5stack-tab5/Source/devices/tab5_keyboard.cpp
• Modules/lvgl-module/include/lvgl/devices/display.h
• Modules/lvgl-module/source/devices/devices.cpp
• Modules/lvgl-module/source/devices/display.cpp
• Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_hid.cpp
• TactilityC/Source/symbols/esp_http_client.cpp
• TactilityC/Source/symbols/freertos.cpp
• TactilityC/Source/tt_init.cpp
• TactilityKernel/include/tactility/drivers/display.h
• TactilityKernel/include/tactility/drivers/keyboard.h
• TactilityKernel/include/tactility/drivers/usb_host_hid.h
• TactilityKernel/source/drivers/keyboard.cpp
• TactilityKernel/source/symbols.c

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 59a1f339-b6dd-46c3-b051-0957915342dc

📥 Commits

Reviewing files that changed from the base of the PR and between aacadc4 and 2c1085c.

📒 Files selected for processing (7)

• Devices/m5stack-papers3/source/drivers/papers3_display.cpp
• Devices/m5stack-tab5/Source/devices/tab5_keyboard.cpp
• Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_hid.cpp
• TactilityC/Source/symbols/esp_http_client.cpp
• TactilityC/Source/symbols/freertos.cpp
• TactilityKernel/include/tactility/drivers/keyboard.h
• TactilityKernel/include/tactility/drivers/usb_host_hid.h

🚧 Files skipped from review as they are similar to previous changes (6)

• TactilityKernel/include/tactility/drivers/keyboard.h
• TactilityKernel/include/tactility/drivers/usb_host_hid.h
• TactilityC/Source/symbols/esp_http_client.cpp
• Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_hid.cpp
• Devices/m5stack-tab5/Source/devices/tab5_keyboard.cpp
• TactilityC/Source/symbols/freertos.cpp

[KenVanHoeylandt]

Thanks a lot! Great improvement!