feat: add deterministic fully-async staleness control - #2278
Draft
0z5a wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a narrow, opt-in policy-version staleness path for fully-async rollout:
--max-policy-version-lag N, accepting a completed group exactly whencurrent_version - group_version <= N;The default lag budget is unset, so existing fully-async behavior is unchanged.
This draft is a deliberately smaller alternative to #1781 for discussion under #1800. It excludes partial-rollout resume,
legacy_backpressure, version-window eviction, and benchmark scripts. The implementation remains split into three commits so the lifecycle, deterministic rejection policy, and observability layers can be reviewed or separated independently.Test plan
uvx pre-commit run --files examples/fully_async/README.md slime/ray/rollout.py slime/rollout/fully_async_rollout.py slime/utils/arguments.py slime/utils/types.py tests/test_fully_async_rollout.py tests/test_megatron_argument_validation.py tests/test_sample.py tests/test_train_async_policy_version.py train_async.pypython -m pytest -q tests/test_fully_async_rollout.py tests/test_megatron_argument_validation.py tests/test_sample.py tests/test_train_async_policy_version.pyCoverage includes monotonic lifecycle publication, failure behavior, disabled-budget compatibility, exact lag-boundary acceptance, stale rejection and pristine requeue, negative argument validation, bounded metric keys, reset semantics, and abort/requeue accounting.
Compatibility
--max-policy-version-lagis set.