Conversation
Remove the existing registry package path before extracting a replacement. Add downgrade coverage for files that only exist in the newer package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix stale files remaining after
tman installreplaces an existing package.Previously, tman extracted the replacement archive directly into the existing
package directory. Files with matching names were overwritten, but files that
did not exist in the replacement package remained on disk.
The existing package path is now removed before extraction, ensuring the
installed directory exactly matches the selected package version.
How This Was Found
While looking for an issue to contribute, I revisited #920. Since the issue was
reported in 2025, I first:
upstream/main;The reproduction used two versions of the same extension:
v2_only.txtfile.tman installreported a successful downgrade, butv2_only.txtremained.Tracing the installation flow showed that the replacement archive was extracted
over the existing directory. The new
installed_pathsonly described filesfrom the replacement package, so it could not identify files left by the
previous version.
Implementation
remove_dir_alldependency for reliable directory removal,including Windows read-only file handling.
its target remains untouched.
Downloading happens before removal, so a download failure leaves the currently
installed package untouched.
Type of Change
Testing
Tests performed:
newer-version-only file.
retains additional files.
target.
compilation, and
git diff --check.Documentation
Documentation updates are not required because this fixes existing installation
behavior without changing the public API or user workflow.
Breaking Changes
None.
Fixes #920