Repository navigation
feat: 建物自体を表すfacilityノードタイプを追加し、UUID形式のnode_id投入に対応 - #3
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
seed CSV（db/seeds/nodes.csv, edges.csv）のnode_idにUUID（ハイフン区切り） を採用したが、chk_node_id_format等の正規表現が^[a-z0-9_]+$のままで ハイフンを許可しておらずINSERTが失敗していたため、 ^[a-z0-9_-]+$に緩和した。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
building_idがNULLの行でis_indoorがNULL(false扱い)として誤って屋外判定 されないよう、COALESCE(n.building_id, -1)で明示的にデフォルト値を補完。 併せてmodel.Node.BuildingIDがDB上NOT NULL(-1がsentinel)でありnilには ならないことをコメントで明記。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodes.node_typeに建物自体を表すfacilityを追加（entrance/facility/door/roadを許容）building_idにDEFAULT -1（建物に属さないノードの統一sentinel）、floorにDEFAULT 1を設定^[a-z0-9_]+$から^[a-z0-9_-]+$に緩和Test plan
go build ./...go vet ./...golangci-lint run ./...（0 issues）🤖 Generated with Claude Code