Skip to content

chore: sync __all__ exports and drop dead sync cleanup - #1765

Merged
SAKURA-CAT merged 1 commit into
mainfrom
chore/tidy
Sep 1, 2026
Merged

SAKURA-CAT merged 1 commit into
mainfrom
chore/tidy

Conversation

@SAKURA-CAT

Copy link
Copy Markdown
Member

Summary

本次是一次小的代码整洁(chore),不涉及任何运行时行为变化:

  1. 补齐两处 __all__ 声明漂移;
  2. 删除一处 sync 侧复制残留的死代码。

Changes

  • swanlab/sdk/internal/pkg/adapter/__init__.py
    • __all__ 补充缺失的 column(该 BiMap 被 transport/sender.py 与 deprecated/sender.py 引用)。
  • swanlab/sdk/internal/core_python/pkg/builder/__init__.py
    • __all__ 补充缺失的 build_column_record(被 core.py 与 sync.py 引用)。
  • swanlab/sdk/internal/core_python/sync.py
    • 删除 confirm_sync_finish 中残留的 self._pending_online_finish_record = None 赋值;该属性仅存在于 CorePython(core.py),CoreSyncPython 从不读取,属复制残留。

Testing

  • uv run ruff check(针对 3 个改动文件):通过
  • uv run pytest tests/unit/sdk/internal/core_python/test_core_sync.py:19 passed

未运行完整单测套件。

Notes

  • 纯声明与死代码清理,无兼容性影响,无新增对外行为。

@SAKURA-CAT SAKURA-CAT added the 💪 enhancement New feature or request label Sep 1, 2026
@SAKURA-CAT SAKURA-CAT self-assigned this Sep 1, 2026
@SAKURA-CAT SAKURA-CAT added the backport release/v0.9 Merge 后自动 backport 此 PR 到 release/v0.9 label Sep 1, 2026
@SAKURA-CAT
SAKURA-CAT merged commit c7f123a into main Sep 1, 2026
20 checks passed
@SAKURA-CAT
SAKURA-CAT deleted the chore/tidy branch September 1, 2026 07:02
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Successfully created backport PR for release/v0.9:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/v0.9 Merge 后自动 backport 此 PR 到 release/v0.9 💪 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant