chore: sync __all__ exports and drop dead sync cleanup - #1765
Merged
Merged
Conversation
|
Successfully created backport PR for |
SAKURA-CAT
added a commit
that referenced
this pull request
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
本次是一次小的代码整洁(chore),不涉及任何运行时行为变化:
__all__声明漂移;Changes
swanlab/sdk/internal/pkg/adapter/__init__.py__all__补充缺失的column(该BiMap被transport/sender.py与deprecated/sender.py引用)。swanlab/sdk/internal/core_python/pkg/builder/__init__.py__all__补充缺失的build_column_record(被core.py与sync.py引用)。swanlab/sdk/internal/core_python/sync.pyconfirm_sync_finish中残留的self._pending_online_finish_record = None赋值;该属性仅存在于CorePython(core.py),CoreSyncPython从不读取,属复制残留。Testing
uv run ruff check(针对 3 个改动文件):通过uv run pytest tests/unit/sdk/internal/core_python/test_core_sync.py:19 passed未运行完整单测套件。
Notes