Skip to content

fix(project-tools): prevent Git review action menu drift - #322

Merged
su-fen merged 1 commit into
mainfrom
codex/fix-git-review-menu-position
Jul 29, 2026
Merged

fix(project-tools): prevent Git review action menu drift#322
su-fen merged 1 commit into
mainfrom
codex/fix-git-review-menu-position

Conversation

@su-fen

@su-fen su-fen commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • decouple Git review section-menu positioning from its scale animation
  • anchor staged and working-change action menus to the trigger right edge with stable boundary correction
  • add GUI and WebUI regression coverage that prevents transform-based positioning from returning

Root cause

The menu used translateX for right alignment on the same element whose entry animation also controlled transform. During the animation, layout measurement observed the temporary scale-only transform and applied an incorrect clamp correction; when the animation ended, translateX returned and shifted the menu again.

Validation

  • node --test crates/agent-gui/test/settings/git-review-menu-position.test.mjs
  • node scripts/check-mirror.mjs
  • GUI: npm run build -- --logLevel error
  • WebUI: npm run build -- --logLevel error
  • git diff --check

@su-fen
su-fen merged commit deb50ed into main Jul 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant