Skip to content

SONARJAVA-6931 ci-autofix: Investigate red master CI #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hashicorp-vault-sonar-prod wants to merge 3 commits into from
Closed

SONARJAVA-6931 ci-autofix: Investigate red master CI #6107

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fef671
ci-autofix: investigate failed CI run 102448842840
hashicorp-vault-sonar-prod[bot] Sep 9, 2026
751b233
fix: avoid potential NPE in InternalCheckVerifier.assertComponentIssue
gitar-bot Sep 9, 2026
f516b08
fix: use null-safe equality in assertAttributeMatch
gitar-bot Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...-testkit/src/main/java/org/sonar/java/checks/verifier/internal/InternalCheckVerifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ private void assertComponentIssue(Set<AnalyzerMessage> issues) {
|| (expectations.expectIssueAtFileLevel() && !issue.getInputComponent().isFile())) {
throw new AssertionError(String.format("Expected the issue to be raised at %s level, not at %s level", component, otherComponent));
}
if (!expectedMessage.equals(issue.getMessage())) {
if (!Objects.equals(expectedMessage, issue.getMessage())) {
throw new AssertionError(String.format("Expected the issue message to be:%n\t\"%s\"%nbut was:%n\t\"%s\"", expectedMessage, issue.getMessage()));
}
}
Expand Down Expand Up @@ -484,7 +484,7 @@ private void assertSuperfluousFlows() {
}

private static void assertAttributeMatch(AnalyzerMessage issue, Object value, Map<Expectations.IssueAttribute, Object> attributes, Expectations.IssueAttribute attribute) {
if (attributes.containsKey(attribute) && !value.equals(attribute.get(attributes))) {
if (attributes.containsKey(attribute) && !Objects.equals(value, attribute.get(attributes))) {
throw new AssertionError(
String.format("line %d attribute mismatch for '%s'. Expected: '%s', but was: '%s'",
issue.getLine(),
Expand Down
Loading