Matter Window Covering: Add embedded clusters for Descriptor, Global clusters#3088
Open
hcarter-775 wants to merge 3 commits into
Open
Matter Window Covering: Add embedded clusters for Descriptor, Global clusters#3088hcarter-775 wants to merge 3 commits into
hcarter-775 wants to merge 3 commits into
Conversation
hcarter-775
requested review from
NoahCornell,
aleclorimer,
cjswedes,
ctowns and
gharveymn
|
Invitation URL: |
Test Results 73 files 521 suites 0s ⏱️ Results for commit 6dbc617. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6dbc617 |
cjswedes
approved these changes
Jul 2, 2026
ctowns
reviewed
Jul 2, 2026
| if version.api < 16 then | ||
| clusters.Global.types.SemanticTagStruct:augment_type(ib.data) | ||
| end | ||
| print("TagList attribute value: ", ib.data) |
ctowns
reviewed
Jul 2, 2026
| if version.api < 20 then | ||
| clusters.ClosureControl = require "embedded_clusters.ClosureControl" | ||
| clusters.ClosureDimension = require "embedded_clusters.ClosureDimension" | ||
| clusters.Global = require "embedded_clusters.Global" |
Contributor
There was a problem hiding this comment.
Shouldn't Global be included if API is <16?
Contributor
Author
There was a problem hiding this comment.
maybe... the Closure clusters depend on Global too so it seemed cleaner to go this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add embedded cluster definitions for Descriptor and Global clusters. Update usages of these in tests and in get_endpoints calls. Use correct can_handle path for all subdrivers in case the v1 lazy loading is invoked.
Summary of Completed Tests
Tests continue to pass as expected in lower firmwares as well as the latest.