Updates

[stefannikolei]

Updated to .net10/.net11
Migrated to slnx
Updated SharedInfrastructure for XUnit.V3 v4 💩💩💩

[stefannikolei]

That test error on .net11 looks really strange. The actual and expected size differ quite a lot. On .net10 everything works.

[JimBobSquarePants]

That test error on .net11 looks really strange. The actual and expected size differ quite a lot. On .net10 everything works.

It’s possible to download the failed artefacts from that test (see ci output for link). We can use that to figure out what is happening.

[stefannikolei]

Reproduced on my machine

.net11

net10

[JimBobSquarePants]

Interesting! So this is one of three things.

A bug in our code
A bug in the runtime
An expected breaking change in the runtime.

[stefannikolei]

Interesting! So this is one of three things.

A bug in our code A bug in the runtime An expected breaking change in the runtime.

would you mind checking it on win?

[JimBobSquarePants]

I'll have to wait until tomorrow my time now. it's late here. Hopefully I can figure it out quickly.

[stefannikolei]

I'll have to wait until tomorrow my time now. it's late here. Hopefully I can figure it out quickly.

When it is not reproducible on win. Then let me know. I can give you access to my Mac.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80%. Comparing base (f5b8b31) to head (f37dafd).

Additional details and impacted files

@@          Coverage Diff           @@
##            main    #558    +/-   ##
======================================
- Coverage     81%     80%    -1%     
======================================
  Files        406     406            
  Lines      35705   35707     +2     
  Branches    5566    5523    -43     
======================================
- Hits       29187   28884   -303     
- Misses      5352    5390    +38     
- Partials    1166    1433   +267     

Flag	Coverage Δ
unittests	80% <100%> (-1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[stefannikolei]

@JimBobSquarePants This is the documentation to the change in the runtime which caused this.

https://github.com/dotnet/core/blob/main/release-notes/11.0/preview/preview7/runtime.md#saturating-floatdouble-conversions-to-small-integral-types

[JimBobSquarePants]

@JimBobSquarePants This is the documentation to the change in the runtime which caused this.

https://github.com/dotnet/core/blob/main/release-notes/11.0/preview/preview7/runtime.md#saturating-floatdouble-conversions-to-small-integral-types

I actually had a hunch it might be that change. it bit me during some testing a while back.

[stefannikolei]

38e1257

@JimBobSquarePants this should probably be picked into the 3.x release to make sure .net 11 is compatible, or