fix(pos): make Storage.current required - #4642
Open
henryStelle wants to merge 1 commit into
Open
Conversation
The host always populates storage.current, so marking it optional forced consumers to handle a 'possibly undefined' case that can never occur.
henryStelle
marked this pull request as ready for review
August 20, 2026 19:16
vctrchu
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes the POS
Storage.currentproperty from optional (current?:) to required for the 2026-10 RC.Why
storage.currentis always populated by the host — it is not actually optional. Marking it optional makes client code awkward: values come back aspossibly undefinedwhen that's inaccurate, forcing unnecessary optional chaining and non-null assertions.Changes
packages/ui-extensions/src/surfaces/point-of-sale/types/storage.ts:current?:→current:ui-extensions-testerPOS factory tests (the tester'screateStoragealready always providescurrent)Checks
yarn build✅yarn test -- packages/ui-extensions-tester/✅ (98 passed)yarn type-check✅yarn lint— only pre-existing failures on gitignored local build artifacts (packages/ui-extensions/{checkout,customer-account}/preact.js), unrelated to this change