fix(recycling): place item separator correctly in inverted lists - #2441
Open
HoshangDEV wants to merge 1 commit into
Open
fix(recycling): place item separator correctly in inverted lists#2441HoshangDEV wants to merge 1 commit into
HoshangDEV wants to merge 1 commit into
Conversation
In an inverted list both the scroller and each cell carry a flip transform, so a cell's trailing separator visually lands between items i and i-1. Every separator shifts one slot toward the start of the list, the two items at the far end sit flush against each other, and a stray separator dangles off the start edge. Render the separator ahead of the item when inverted so it still falls between items i and i+1. Related to Shopify#638
4 tasks
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In an inverted list,
ItemSeparatorComponentlands on the wrong side of the item: every separator shifts one slot toward the start, the last two items sit flush against each other, and a stray separator dangles off the start edge.invertedapplies a flip transform to both the scroller (useSecondaryProps) and each cell (ViewHolder), so the two cancel inside the cell but the cells themselves are mirrored — a cell's trailing edge points at index − 1, not index + 1. The fix is placement only: render the separator ahead of the item when inverted.leadingItem/trailingItemsemantics, the last-row suppression inViewHolderCollection, and measured cell size are all unchanged.Related to #638, which reported this against 1.3.0 and still reproduces on 2.3.2.
Reviewers' hat-rack 🎩
ViewHolder.tsxis the whole basis of the fix — worth confirming independently.numColumns > 1) should follow the same argument, but have no dedicated coverage in this PR.Screenshots or videos (if needed)
InvertedTeston the iOS simulator (iPhone 17, iOS 26.5). The fixture screen was temporarily tweaked to make the effect legible — separator 12px red instead of 1px grey, and 5 items so both ends of the list fit on screen. Those tweaks are not part of this PR.Before: Item 4 and Item 3 are flush with no separator between them, and a stray separator sits below Item 0 against the header. After: a separator between all four adjacent pairs, and both outer edges clean.
Test plan
yarn test(189 passed, 15 suites),yarn type-check,yarn lintsrc/__tests__/InvertedSeparator.test.tsxasserts separator-vs-item order per cell in both directions, and was confirmed to fail on unmodifiedmainfor the inverted case