[Feature] Add intercepts target capability support - #8345
Draft
henryStelle wants to merge 1 commit into
Draft
Conversation
Assisted-By: devx/e5cddb80-0e3c-436a-875b-f96ba8a73082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/shop/issues-retail/issues/33526
Depends on: https://meteorite.shopify.io/repos/shop/world/pulls/2005826
WHY are these changes introduced?
UI extension target configurations currently recognize only
allow_direct_linkingunder target capabilities, sointerceptsdeclarations are not retained when the configuration is parsed.WHAT is this pull request doing?
interceptsUI extension target capability.allow_direct_linking.interceptsconfiguration is retained through parsing and transformation.@shopify/app.Schema note
interceptsintentionally accepts a loosely typed payload during limited testing so the configuration contract can evolve without coupling iteration to CLI releases. This form will not be publicly documented. Before broader availability and public documentation, we plan to replace it with a stricter schema that reflects the finalized contract.How to test your changes?
dev test packages/app/src/cli/models/extensions/specifications/ui_extension.test.ts— 53 tests passeddev lintdev type-checkgit diff --checkChecklist