Filter explicit store lookups to active stores#7529
Open
dmerand wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
no-changelog
dmerand
temporarily deployed
to
breaking-change-approval
GitHub Actions
Inactive
dmerand
force-pushed
the
donald/list-app-dev-stores-store-status-filter
branch
from
59a45b9 to
e3c4376
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Business Platform “store-by-domain” lookup path to exclude inactive/deleted stores, aligning explicit --store flows with the active-store filtering already applied to the app dev store list.
Changes:
- Add
STORE_STATUS=ACTIVEto the filter set used bystoreByDomainfor every requested store type. - Remove the prior “follow-up” breadcrumb comment now that the filtering behavior is implemented.
- Add unit tests covering the request shape (including
STORE_STATUS=ACTIVE) and a mixed store-type lookup that resolves on the second result.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts | Tightens storeByDomain query filters to only return active stores. |
| packages/app/src/cli/utilities/developer-platform-client/app-management-client.test.ts | Adds focused coverage verifying active-store filtering and mixed store-type lookup behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Filter explicit Business Platform store lookups to active stores.
This makes
storeByDomainapply the same active-store constraint that PR #7500 already added to the app dev store selection list.Why
The list path stopped surfacing inactive or deleted stores, but explicit domain lookup still only filtered by store type.
That left
--storeflows able to resolve stores the CLI should no longer treat as valid, including mixed store-type callers likestore execute.How
STORE_STATUS=ACTIVEtostoreByDomainFiltersfor every requested store typeTesting
To test:
shopify app dev --store <inactive-dev-store>and confirm the CLI does not resolve itshopify store execute --store <inactive-or-deleted-store> --query '{ shop { name } }'and confirm the lookup fails instead of selecting that store