Skip to content

[Refactor] Extract shared execution environment logic in system.ts#7515

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-system-env-logic-9574303689973063028
Draft

[Refactor] Extract shared execution environment logic in system.ts#7515
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-system-env-logic-9574303689973063028

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The packages/cli-kit/src/public/node/system.ts file contained duplicated logic for preparing the execution environment (setting FORCE_COLOR and determining the cwd) across three different functions: captureCommandWithExitCode, execCommand, and buildExec.

WHAT is this pull request doing?

This PR extracts the shared environment and CWD setup logic into a new private helper function getExecutionEnvironment. It then refactors captureCommandWithExitCode, execCommand, and buildExec to use this helper, improving maintainability and reducing code duplication.

How to test your changes?

Run the unit tests for system.ts:
pnpm vitest run packages/cli-kit/src/public/node/system.test.ts

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type and added a changeset with pnpm changeset add

Duplicate check

I performed a duplicate check using git log --grep="\[Refactor\]" --grep="Jules" --oneline as gh is not available. No previous PRs were found targeting this specific duplication in system.ts.


PR created automatically by Jules for task 9574303689973063028 started by @gonzaloriestra

Extract shared environment and CWD setup logic into a new private helper
function `getExecutionEnvironment` in `packages/cli-kit/src/public/node/system.ts`.
This refactor reduces duplication in `captureCommandWithExitCode`,
`execCommand`, and `buildExec`.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 11, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant