[E2E] Rename E2ETestIds to AccessibilityIdentifiers - #650
Open
kyle-schellen wants to merge 1 commit into
Open
Conversation
Package Size
React Native file breakdown
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Renames
E2ETestIdstoAccessibilityIdentifiersin the three sample apps, and moves it out of each sample'se2e/folder into a siblingaccessibility/folder.Follow-up to Mark's comment on #560:
The samples are reference code merchants read to learn Checkout Kit. They don't need to know we drive these apps with an E2E suite, so our test vocabulary shouldn't show up in the screens they're reading.
AccessibilityIdentifiersis also just the more accurate name — these are applied viaaccessibilityIdentifier,testTagandtestID.The file moves out of
e2e/for the same reason: leaving it there would keepe2ein the import line of every screen.No behaviour change. Every identifier value is byte-for-byte identical, so no Maestro flow, tag or matrix entry is affected.
Still in
e2e/: the harness itself (E2EController,E2EControlLink,E2ESampleAppTarget,useE2ECartBootstrap). That code really is test infrastructure, and the label is what tells a merchant to skip the folder.How to test
CI covers all three platforms.
Before you merge
Important