refactor(swift): log message rejections as warnings - #646
Open
tiagocandido wants to merge 1 commit into
Open
Conversation
Remove Configuration.onMessageRejected and the public MessageRejection type before they ship in a release. Origin-validation rejections are now always logged at warn level with the trusted origin and reason; the untrusted message body is never logged. Child-frame messages are ignored at debug level as ambient noise.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 14, 2026
tiagocandido
marked this pull request as ready for review
August 14, 2026 15:05
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
markmur
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Remove
Configuration.onMessageRejectedand the publicMessageRejectiontype while they have only shipped in an alpha. Origin validation keeps a single configuration surface:allowedMessageOrigins.Rejected messages are never silently dropped — each rejection is logged as a warning with the trusted origin and reason. The untrusted message body is not logged. Child-frame messages are ignored at debug level as ambient noise. A structured observability API for rejections can be added later without a breaking change.
How to test
From
platforms/swift:./Scripts/xcode_run test ShopifyCheckoutKit-Package ./Scripts/api check