Skip to content

Add GNUInstallDirs to CMakeLists.txt#21

Open
mesmith75 wants to merge 1 commit into
mainfrom
mesmith75-patch-1
Open

Add GNUInstallDirs to CMakeLists.txt#21
mesmith75 wants to merge 1 commit into
mainfrom
mesmith75-patch-1

Conversation

@mesmith75
Copy link
Copy Markdown

@mesmith75 mesmith75 commented May 28, 2026

Fixes the install locations

Summary by CodeRabbit

  • Chores
    • Updated build configuration to improve consistency in installation directory handling.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7a4f358-2ec6-481e-87f0-bcf4b3a182c4

📥 Commits

Reviewing files that changed from the base of the PR and between d9d4713 and 34f91b1.

📒 Files selected for processing (1)
  • CMakeLists.txt

📝 Walkthrough

Walkthrough

CMakeLists.txt adds an early include(GNUInstallDirs) call at line 5, making the module available earlier in the build configuration. The same module is already included later for installation rules, creating a duplicate inclusion.

Changes

CMake Build Configuration

Layer / File(s) Summary
Early GNUInstallDirs inclusion
CMakeLists.txt
include(GNUInstallDirs) is added near the top of the file at line 5, supplementing the existing later inclusion in the installation section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ShipSoft/Geometry#17: Introduces installation rules that depend on CMake variables provided by GNUInstallDirs, which this PR makes available earlier in the configuration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding GNUInstallDirs to CMakeLists.txt, which is clear and directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mesmith75-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mesmith75 mesmith75 requested review from THanae and olantwin May 28, 2026 21:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

Copy link
Copy Markdown
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll squash this to adjust the commit message. Looks good to me otherwise.

This might need some downstream adjustments to shipdist or the other packages, but we can fix them as they arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants