Add "Reuse existing mechanisms" design principle to CLAUDE.md#530
Merged
Conversation
Adds a Code Style rule: comments, docstrings, `desc=` strings, and error messages should describe what the thing does, not which model/algorithm/caller/feature uses it. References like "applied to GRPO/GSPO" rot when consumers change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Both commands now begin their output with `## /review-<kind> @ <short-sha>`, which makes the output recognizable when pasted into another session for review triage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Recurring friction across sessions: reaching for an ad-hoc helper or config shape when the framework already provides a canonical mechanism (Config update mechanism, PretrainedFastLLMModelConfig, config-flag logging). Codify the reuse-first expectation alongside the existing design principles. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 4.8 note: authored on Joel's behalf.
Adds one Design principle to
CLAUDE.md:Motivation: recurring friction where ad-hoc helpers/config shapes were written when a first-class framework mechanism already existed.
🤖 Generated with Claude Code