feat[OBE-11604]: Wire JwtBearer auth strategy into sauth and scol - #132
Open
akshayakumar-t wants to merge 10 commits into
Open
feat[OBE-11604]: Wire JwtBearer auth strategy into sauth and scol#132akshayakumar-t wants to merge 10 commits into
akshayakumar-t wants to merge 10 commits into
Conversation
Wire jwt-bearer feature in sauth (smpl_jwt + reqwest with rustls-tls), update submodule pointer, and switch scol's sauth dependency from the old gcp feature to jwt-bearer. Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
akshayakumar-t
changed the title
Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
Swap smpl_jwt (OpenSSL, padded base64url) for jsonwebtoken (ring, RFC 7515 compliant) in the jwt-bearer feature. Remove base64 dev-only dep that was only needed by the now-deleted decode_jwt_iss helper. Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
Make jsonwebtoken and reqwest unconditional dependencies in sauth. Remove the jwt-bearer feature from sauth/Cargo.toml and drop the features = ["jwt-bearer"] reference from scol's dependency. Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
…bearer docs Promote url crate from optional to unconditional dep in sauth so build() can parse token_url and compare Host enum variants exactly. Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
Co-Authored-By: Akshaya's Agent <akshaya.kumar+agent@sentinelone.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jwt-bearerfeature tosauth(smpl_jwt+reqwestwith rustls-tls, no OpenSSL)scol's sauth dependency from the oldgcpfeature tojwt-bearerdataplane-privateTest plan
FEATURES=observo cargo checkpassescargo test -p sauth --features jwt-bearer,test-support— all 6 jwt_bearer tests pass