Handle undecidable properties as assignments#203
Merged
Conversation
ScriptRaccoon
force-pushed
the
rework-undecidable-properties
branch
from
124937f to
f586a1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #82 in a cleaner way than before (#140). Previously, undecidable properties were stored in a separate table,$M$ -sets, for example, continued to appear in the list of categories with missing data, even though all properties had already been assigned as either satisfied, unsatisfied, or undecidable. Similarly, FreeAb was shown as having two unknown properties, even though only one property is currently unknown.
category_property_comments, while still being listed among the unknown properties. This was not ideal. It also meant that the category ofIt is more natural to treat proven undecidability as an assignment. To support this, the
is_satisfiedfield in thecategory_property_assignmentstable, which was previously boolean, may now also benull, indicating that the property is undecidable.This required updates in various parts of the application. The category page also looks slightly different now for categories with undecidable properties, of which there are currently only two.
Before
After
(we did not decide new properties, but rather, the number has been fixed)