Skip to content

⚡ Optimize MarqueeSection scroll performance #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SayanthRock wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize MarqueeSection scroll performance #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 29 additions & 15 deletions src/sections/MarqueeSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useRef, useEffect, useState } from 'react';
import { useRef, useEffect } from 'react';

const gifs = [
"https://motionsites.ai/assets/hero-space-voyage-preview-eECLH3Yc.gif",
Expand Down Expand Up @@ -29,19 +29,37 @@ const row2 = [...gifs.slice(11), ...gifs.slice(11), ...gifs.slice(11)];

export const MarqueeSection = () => {
const sectionRef = useRef<HTMLDivElement>(null);
const [offset, setOffset] = useState(0);
const row1Ref = useRef<HTMLDivElement>(null);
const row2Ref = useRef<HTMLDivElement>(null);

useEffect(() => {
const handleScroll = () => {
if (!sectionRef.current) return;
let ticking = false;

const updatePosition = () => {
if (!sectionRef.current || !row1Ref.current || !row2Ref.current) {
ticking = false;
return;
}

const sectionTop = sectionRef.current.offsetTop;
const newOffset = (window.scrollY - sectionTop + window.innerHeight) * 0.3;
setOffset(newOffset);
const offset = (window.scrollY - sectionTop + window.innerHeight) * 0.3;

row1Ref.current.style.transform = `translate3d(${offset - 200}px, 0, 0)`;
row2Ref.current.style.transform = `translate3d(${-(offset - 200)}px, 0, 0)`;

ticking = false;
};

const handleScroll = () => {
if (!ticking) {
window.requestAnimationFrame(updatePosition);
ticking = true;
}
};

window.addEventListener('scroll', handleScroll, { passive: true });
// Initial call to set correct position on load
handleScroll();
updatePosition();

return () => window.removeEventListener('scroll', handleScroll);
}, []);
Expand All @@ -54,11 +72,9 @@ export const MarqueeSection = () => {
<div className="flex flex-col gap-3">
{/* Row 1 - Moves Right */}
<div
ref={row1Ref}
className="flex gap-3 w-max"
style={{
transform: `translate3d(${offset - 200}px, 0, 0)`,
willChange: 'transform'
}}
style={{ willChange: 'transform' }}
>
{row1.map((src, idx) => (
<img
Expand All @@ -73,11 +89,9 @@ export const MarqueeSection = () => {

{/* Row 2 - Moves Left */}
<div
ref={row2Ref}
className="flex gap-3 w-max"
style={{
transform: `translate3d(${-(offset - 200)}px, 0, 0)`,
willChange: 'transform'
}}
style={{ willChange: 'transform' }}
>
{row2.map((src, idx) => (
<img
Expand Down