SBND Timing Reconstruction Refactor by VCLanNguyen · Pull Request #637 · SBNSoftware/sbncode

VCLanNguyen · 2026-03-04T01:42:15Z

Description

Timing reconstruction is refactored in this PR, affecting the decode/reconstruction workflow of CRT/PMT/XA.
After the refactoring, the @FrameShiftModule@ runs first in the decode chain, outputs timing products to be used at PMT/XA decoder and CRTStrip reconstruction.
Relevant PMT reconstruction modules at Reco1/Reco2 are updated.
The timing correction applied at CAFMakeer is undone. This should ressolve this issue: Converge timing correction in CAFMaker for SBND and ICARUS #567
Details and validation plots can before in the linked docdb.

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=45982

Relevant PR links (optional)

This PR needs the XA decoder PR in sbndcode to go in first:
SBNSoftware/sbndcode#847

This PR needs to be merged together with this group of PRs:

sbndcode: SBND Timing Reconstruction Refactor sbndcode#915
sbncode: SBND Timing Reconstruction Refactor #637
sbnobj: SBND Timing Reconstruction Refactor sbnobj#170
sbnanaobj:SBND Timing Reconstruction Refactor sbnanaobj#188

Checklists

Have you added a label? (bug/enhancement/physics etc.)
Have you assigned at least 1 reviewer?
Is this PR related to an open issue / project?
Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

…b.com/SBNSoftware/sbncode into feature/frame_shift_refactor_v10_14_02

VCLanNguyen · 2026-04-21T18:05:08Z

@JosiePaton @PetrilloAtWork can you guys review for CAF?

PetrilloAtWork

Ops... added the comment for a different PR here.
This PR is actually fine, although I would appreciate you considering the changes I mentioned below (in particular, the bit-wise & operator is semantically wrong there, even if it works as it should).
Re-request the review of this PR after considering these, for quick approval.

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

Removed legacy timing correction code for SBND.

PetrilloAtWork

My comments were addressed. Approved!

v10_20_05

hgreenlee · 2026-05-26T20:21:02Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_20_09 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_20_08 sbnobj#170 sbnanaobj#188 sbndcode#915

FNALbuild · 2026-05-26T20:36:26Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-05-26T20:37:48Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-05-26T20:45:46Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T20:46:12Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T20:46:17Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

hgreenlee · 2026-05-26T20:48:02Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_20_08 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_20_08 sbnobj#170 sbnanaobj#188 sbndcode#915

FNALbuild · 2026-05-26T20:48:24Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T21:04:24Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-05-26T21:05:44Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-05-26T21:09:57Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T21:10:07Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T21:16:14Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T21:20:10Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

hgreenlee · 2026-05-26T21:52:42Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_20_08 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_20_08 SBNSoftware/sbnobj#170 SBNSoftware/sbnanaobj#188 SBNSoftware/sbndcode#915

VCLanNguyen · 2026-05-26T22:04:56Z

Hi @hgreenlee

I triggered a manual CI test that ran successfully, see CI test#20777 at https://dbweb1.fnal.gov:8443/LarCI/app/ns:SBND/view_builds/index

Ci test ran successfully in sequence mode (CI root file went through decode > reco1 > reco2 > caf) instead of quick mode (reference CI root file input to individual stage)
This is required since the PR changes are implemented at the decode stage. CI reference files will need to be updated.

CI results:

MC workflow caf results are different. This is due to PRs change the default non-initialization value.
Data workflow caf results are different. This is due to PRs update the sbnd_frames data products from double to uint_64t so the change is expected.

Summary:

CI test ran fine in sequence modes. Warnings are consistent with the PR changes.
CI reference files need to be updated.

FNALbuild · 2026-05-26T22:07:10Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-05-26T22:09:03Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-05-26T22:15:48Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T22:16:21Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T22:17:04Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-26T22:20:11Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

hgreenlee · 2026-05-27T18:04:18Z

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_20_09 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_20_09

VCLanNguyen added 4 commits November 11, 2025 16:25

temporary comment timing-related in caf

2daacc4

Update CafMaker for refactoring frameshift module

340f043

Merge branch 'feature/frameshift_refactor_v10_11_01' of https://githu…

5810b0f

…b.com/SBNSoftware/sbncode into feature/frame_shift_refactor_v10_14_02

update comments in cafmaker

330f278

This was referenced Mar 4, 2026

SBND Timing Reconstruction Refactor SBNSoftware/sbndcode#915

Merged

SBND Timing Reconstruction Refactor SBNSoftware/sbnobj#170

Merged

SBND Timing Reconstruction Refactor SBNSoftware/sbnanaobj#188

Merged

VCLanNguyen changed the title ~~Feature/frame shift refactor v10 14 02~~ SBND Timing Reconstruction Refactor Mar 4, 2026

VCLanNguyen self-assigned this Mar 4, 2026

VCLanNguyen added breaking change dependent An issue or PR depending on another labels Mar 4, 2026

VCLanNguyen requested a review from PetrilloAtWork April 14, 2026 14:56

VCLanNguyen requested a review from JosiePaton April 21, 2026 18:04

PetrilloAtWork requested changes Apr 28, 2026

View reviewed changes

Comment thread sbncode/CAFMaker/FillTrigger.cxx Outdated

Comment thread sbncode/CAFMaker/FillTrigger.cxx Outdated

Comment thread sbncode/CAFMaker/CAFMaker_module.cc Outdated

VCLanNguyen and others added 3 commits May 6, 2026 08:31

Update sbncode/CAFMaker/FillTrigger.cxx

82261dc

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

Update sbncode/CAFMaker/FillTrigger.cxx

f931576

Co-authored-by: Gianluca Petrillo <petrillo@slac.stanford.edu>

Remove legacy timing correction for SBND

3f47621

Removed legacy timing correction code for SBND.

VCLanNguyen requested a review from PetrilloAtWork May 6, 2026 22:48

PetrilloAtWork approved these changes May 7, 2026

View reviewed changes

Merge tag 'v10_20_05' into feature/frame_shift_refactor_v10_14_02

621fdbb

v10_20_05

hgreenlee merged commit 23f373e into develop May 27, 2026
2 of 6 checks passed

Conversation

VCLanNguyen commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Link(s) to docdb describing changes (optional)

Relevant PR links (optional)

Checklists

Uh oh!

VCLanNguyen commented Apr 21, 2026

Uh oh!

PetrilloAtWork left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PetrilloAtWork left a comment

Choose a reason for hiding this comment

Uh oh!

hgreenlee commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

hgreenlee commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

hgreenlee commented May 26, 2026

Uh oh!

VCLanNguyen commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

FNALbuild commented May 26, 2026

Uh oh!

Uh oh!

hgreenlee commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VCLanNguyen commented Mar 4, 2026 •

edited

Loading

PetrilloAtWork left a comment •

edited

Loading