fix(agentgateway): guard MCP session handshake with anyio.fail_after - #353
Open
cassiofariasmachado wants to merge 3 commits into
Open
cassiofariasmachado wants to merge 3 commits into
cassiofariasmachado wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an AGW MCP endpoint returns HTTP 200 with
Content-Type: text/event-streambut a plain-text error body (e.g."Jwt issuer is not configured"),list_mcp_toolshangs indefinitely. Thehttpx-sseSSEDecodersilently discards all non-SSE lines, so no events are ever yielded, nothing is written to the response stream, andsession.initialize()/session.list_tools()block forever.Wraps the MCP session handshake (
initialize+list_tools) in bothlist_server_tools(_lob.py) and_list_server_tools(_customer.py) withanyio.fail_after(timeout), reusing the existingtimeoutparameter fromClientConfig(default 60 s). On expiry,TimeoutErroris raised and caught by theasyncio.gather(return_exceptions=True)callers, which log it and continue.Related Issue
Related to #348
Type of Change
How to Test
Content-Type: text/event-streamand a plain-text body (e.g. a misconfigured JWT issuer).client.list_mcp_tools(...)— previously hangs forever, now raisesTimeoutErrorafter the configured timeout.uv run pytest tests/agentgateway/unit/ -v— all 257 pass.Checklist
Additional Notes
anyiois already a transitive dependency viamcp— no new dependencies introduced.