fix(ci): make version-bump check against merge-base - #330
Merged
Merged
Conversation
jplbrun
marked this pull request as ready for review
September 11, 2026 22:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Check Version Bump workflow diffs
github.event.pull_request.base.shaagainsthead.shato decide whether a version bump is required. That base SHA is the commitmainpointed at when the PR was last synced, and it drifts behindmainas other PRs merge. As a result the diff includessrc/**/*.pyfiles from already-merged PRs that the current branch never touched, so the check wrongly demands a version bump and a documentation-only PR ends up failing because unrelated source files appear in the comparison.This changes the check to diff against the merge-base of the base and head commits (the point where the branch actually diverged from
main) instead of the raw base ref.Related Issue
N/A
Type of Change
How to Test
Reproduced locally using the workflow's own logic against a drifted PR's real SHAs:
base.sha): source files from already-merged PRs appear in the diff → check FAILS demanding a version bump.No source file changes under src/. Version bump not required.→ check PASSES.src/**/*.pychange without a version bump still matches the regex and FAILS with the existing error — enforcement is unchanged for real source changes.Also tested end-to-end : applying the fix to docs-only PR branch (#329) flipped Check Version Bump from failing to passing.
Checklist
Breaking Changes
None
Additional Notes
None