Repository navigation
fix(version-check): preserve HTTPS guard in test - #151
Merged
Merged
Conversation
Potential fix for code scanning alert no. 16: Failure to use HTTPS URLs Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
shadowhand
marked this pull request as ready for review
October 13, 2026 08:34
Co-authored-by: shadowhand <38203+shadowhand@users.noreply.github.com>
shadowhand
changed the title
shadowhand
commented
Oct 13, 2026
Co-authored-by: shadowhand <38203+shadowhand@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/RoundingWell/app-cli/security/code-scanning/16
Enforce HTTPS in
fetch_latest_versionbefore issuing the request, and update the test URL literal to HTTPS to avoid tainting with an HTTP source.Best minimal fix (without changing intended functionality):
src/version_check.rs, insidefetch_latest_version, add an early return ifurldoes not start withhttps://."http://unused"to"https://unused".This preserves behavior:
Nonerather than making insecure requests.No new imports or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.