Fix Fast image-only Slack follow-ups - #1483
Closed
daniel-lxs wants to merge 1 commit into
Closed
Conversation
Contributor
Member
Author
|
Closing because this replacement was created from the same PR-number mix-up. No code from this PR was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
!fastusage hintWhy
Slack can omit file metadata from the event while returning it through
conversations.replies. Fast already recovers that thread metadata for text-plus-image turns, but it decided an empty-text turn was invalid before fetching the thread, so image-only follow-ups never reached the model.Bounding the images before download and again before inference keeps large Slack posts from creating unbounded multimodal payloads.
This supersedes the remaining useful behavior from #1446; the underlying native-session screenshot support already shipped in #1474.
Validation
@roomote/api: 207 test files, 1,799 tests@roomote/cloud-agents: 99 test files, 775 testspnpm check-typespnpm lintpnpm knipSmoke test
Mock Slack
app-mention-fastpassed against pushed head50a39ba7using OpenCode 1.18.10: