[Fix] Fast mode replies to ambient participant conversation - #1459
Draft
roomote-roomote[bot] wants to merge 4 commits into
Draft
[Fix] Fast mode replies to ambient participant conversation#1459roomote-roomote[bot] wants to merge 4 commits into
roomote-roomote[bot] wants to merge 4 commits into
Conversation
Contributor
…r-responses-20m1xglvlsreh
…r-responses-20m1xglvlsreh
| defaultFastMessage.id, | ||
| ), | ||
| activeTasks: activeRun ? [{ taskId: activeRun.taskId }] : [], | ||
| directedAtRoomote: |
Contributor
There was a problem hiding this comment.
A native Discord reply to a Roomote message has a message_reference but need not contain an @mention. In a shared Fast thread this passes directedAtRoomote: false, so ignore_message becomes valid and the model can silently discard a reply that was directly addressed to Roomote. Classify replies whose referenced message is Roomote-authored as directed as well (and add a regression test).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Fast mode treated every routed human message as requiring a visible response, which made it interrupt conversations between other thread participants. Standard task threads already distinguish messages directed at Roomote from passive thread activity.
Impact
Roomote can remain silent when people are talking to each other in an established Fast thread, while continuing to answer messages that are actually addressed to it. New participants can still join the Fast conversation naturally without losing explicit mention handling.