build(cmake): Fetch DX9 SDK via FetchContent instead of hardcoded path - #3
Closed
bobtista wants to merge 1 commit into
Closed
build(cmake): Fetch DX9 SDK via FetchContent instead of hardcoded path#3bobtista wants to merge 1 commit into
bobtista wants to merge 1 commit into
Conversation
Replace the hardcoded "C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)" dependency with CMake FetchContent using stephanmeesters/min-dx9-sdk. This allows the project to build out of the box without requiring a manual SDK installation. Also adds a d3d8lib alias target so that GUIEdit and WorldBuilder (which still reference d3d8lib) link correctly through the DX9 SDK.
bobtista
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C:/Program Files (x86)/Microsoft DirectX SDK (June 2010)dependency incmake/dx9.cmakewith CMakeFetchContentusing stephanmeesters/min-dx9-sdk, a minimal DX9 SDK repo (294 KB) containing headers and x86 libsd3d8libalias target so GUIEdit and WorldBuilder (which still referenced3d8lib) link correctly through the DX9 SDKif(NOT TARGET ...)to avoid conflicts with MinGW buildsThis follows the same
FetchContentpattern that upstream TheSuperHackers uses for the DX8 SDK viamin-dx8-sdk.Test plan
d3d8lib)