docs: the last narrow check commands say what they leave out - #731
Merged
Conversation
The check tables in AGENTS.md and CONTRIBUTING.md already label their rows as the inner loop and say per row what each command does not cover. Three other places still named a narrow command as the check with nothing beside it: the README's "Common checks" line (kernel-only mypy, no browser), the kernel architecture page (the kernel-only mypy as the mypy run), and the frontend architecture page (three workspace commands, the browser suites unmentioned). Each now says it is a subset of what CI runs and what the rest is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check-command subset issue (#674) recorded two things: a kernel-scoped
mypyand a browser-free frontend command were being read as the checks, and the decision (2026-08-18) to keep those narrow commands as an explicitly labelled inner loop with the subset relationship stated per row. Most of that decision is already onmain. The one-home-per-rule consolidation (#705) gaveAGENTS.mdits inner-loop table with a does not cover column and named the two change categories that always escalate — state, gating or progress, and the shape of a published wire model — and the targeted-checks follow-up (#706) reconciledCONTRIBUTING.mdand the skills to the same statement. This pull request finishes the issue by fixing the three places that still named a narrow command as the check with nothing beside it.What changed
README.mdcalleduv run mypy src/visionset/kernelandpnpm test"common checks" and pointed atCONTRIBUTING.mdonly for the wheel build and the thirty-minute flow. The line now calls them the inner loop, says beside each what it leaves out — the kernel only, no browser — and states that every command there is a subset of what CI runs on each pull request, linking to the section that lists what each one does not cover.docs/content/architecture/backend/kernel.mdpresented the kernel-onlymypyas the mypy run. The strict flags are per-module configuration inpyproject.toml, souv run mypy src/visionset— what CI runs — applies them to the kernel and the ordinary ones everywhere else; the page now says so and names the kernel-only command as the iterating subset that sees nothing outside the kernel.docs/content/architecture/frontend/README.mdlisted the three workspace commands and saidcheck.sh"runs all three, plus the two browser suites", which leaves the reader to infer that the three run no browser. It now says that directly — anything only chromium can see passes them — and that CI runs all five on every pull request.One clause of the decision is superseded, and this records it
The decision comment on the issue says a full local pass happens once, immediately before a pull request is opened. The targeted-checks change (#706) moved the policy past that:
bash scripts/check.shis the comprehensive local run for the moments a developer deliberately chooses its cost, and is no longer a routine step before a commit, push, or pull request. The reading-CI obligation and the two escalation categories from the decision stand unchanged inAGENTS.md. Nothing here reopens that; the issue is closed against the policy asmainnow states it.Test plan
Targeted, per the policy. The docs site link check runs in CI as
docs site.Found, not fixed
Nothing.
Closes #674