Skip to content

add rqt JTC - #426

Open
PeterMitrano wants to merge 2 commits into
RoboStack:mainfrom
PeterMitrano:add-rqt-joint-trajectory-controller
Open

PeterMitrano wants to merge 2 commits into
RoboStack:mainfrom
PeterMitrano:add-rqt-joint-trajectory-controller

Conversation

@PeterMitrano

Copy link
Copy Markdown
Contributor

By the way, when I built locally I get this:

 │ │ ⚠ warning Warnings:
 │ │ ⚠ warning Overdepending against ros-humble-control-msgs
 │ │ ⚠ warning Overdepending against ros-humble-controller-manager-msgs
 │ │ ⚠ warning Overdepending against ros-humble-python-qt-binding
 │ │ ⚠ warning Overdepending against ros-humble-qt-gui
 │ │ ⚠ warning Overdepending against ros-humble-rqt-gui
 │ │ ⚠ warning Overdepending against ros-humble-rqt-gui-py
 │ │ ⚠ warning Overdepending against ros-humble-trajectory-msgs
 │ │ ⚠ warning Overdepending against rospkg

What does that mean? Is it something we should address in this PR (while we're here)

@traversaro

Copy link
Copy Markdown
Member

By the way, when I built locally I get this:

 │ │ ⚠ warning Warnings:
 │ │ ⚠ warning Overdepending against ros-humble-control-msgs
 │ │ ⚠ warning Overdepending against ros-humble-controller-manager-msgs
 │ │ ⚠ warning Overdepending against ros-humble-python-qt-binding
 │ │ ⚠ warning Overdepending against ros-humble-qt-gui
 │ │ ⚠ warning Overdepending against ros-humble-rqt-gui
 │ │ ⚠ warning Overdepending against ros-humble-rqt-gui-py
 │ │ ⚠ warning Overdepending against ros-humble-trajectory-msgs
 │ │ ⚠ warning Overdepending against rospkg

What does that mean? Is it something we should address in this PR (while we're here)

No. rattler-build warns if a package has a run dependency on another package and the dependant package has a shared library and that library is not used as a link. However, run dependencies can be there for several reason different from a library actually be used, so I think it is safe to ignore those warnings.

@traversaro

Copy link
Copy Markdown
Member

@PeterMitrano can you look into the Windows failure, or only add the problematic packages on *nix? Thanks!

@gftabor

gftabor commented Sep 28, 2026 •

Copy link
Copy Markdown

The packages failing seem to have never built for windows

https://prefix.dev/channels/robostack-humble/packages/ros-humble-autoware-internal-localization-msgs

All windows CI has been broken for months
https://github.com/RoboStack/ros-humble/actions/workflows/win.yml

@gftabor

gftabor commented Sep 28, 2026

Copy link
Copy Markdown

Okay so empy4 support is added in build number 19 of rosidl_adapter. However the CI has never built build 19 of rosidl_adapter on windows.

autoware_internal_localization_msgs is failing because it needs build 19 of rosidl_adapter. The CI fails there and then never tries to rebuild rosidl_adapter.

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Time to merge #420? :)

@gftabor

gftabor commented Sep 29, 2026

Copy link
Copy Markdown

Time to merge #420? :)

That should fix this at least. I say merge away

@traversaro

Copy link
Copy Markdown
Member

Time to merge #420? :)

That should fix this at least. I say merge away

Just merged. If you wait a few hours, then it would be probably a good idea to rebase on top of the latest main!

@PeterMitrano
PeterMitrano force-pushed the add-rqt-joint-trajectory-controller branch from c5ea691 to 376f6f0 Compare September 29, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants