Fix UnicodeDecodeError decoding adb output on Windows (cp1252)#40
Merged
Conversation
subprocess ran with text=True, which decodes with the locale default (cp1252 on Windows). A module's install log (e.g. Integrity Box) can emit bytes cp1252 can't decode (0x9d), crashing subprocess's reader thread mid-install and dumping a traceback -- and breaking the fallback error message that reads that output. Decode as UTF-8 with errors='replace' so odd bytes can never crash it. Adds a regression test that runs the real _run against a process emitting the exact 0x9d byte.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the _run function in adb_handler.py to use UTF-8 encoding and replace decoding errors when running subprocesses. This prevents potential UnicodeDecodeError exceptions on Windows when handling non-standard characters (such as emojis or box-drawing characters) in adb or magisk logs. There are no review comments, and we have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module-install subprocess ran with
text=True, decoding adb/magisk output with Windows' default cp1252. A module's install log (hit with Integrity Box) emitted byte0x9d, which cp1252 can't decode — crashing subprocess's reader thread mid-install with a traceback, and (worse) breaking the fallback error message that reads that same output.Fix: decode as UTF-8 with
errors='replace'so odd bytes are replaced, never raised. Adds a regression test that runs the real_runagainst a process emitting the exact0x9dbyte and asserts it survives. 19/19 offline tests pass.